Rename StopWatch to Stopwatch. Add new Stopwatch.start() and Stopwatch.reset().

Rename StopWatch to Stopwatch. Add new Stopwatch.start() and Stopwatch.reset().

BUG=dart:418
TEST=
Committed: https://code.google.com/p/dart/source/detail?r=1505

[floitsch, 2011-11-11 13:57:48]

I modified corelib/StopwatchTest.dart (in addition to renaming it). If you want
to look at the changes, please look at patch set 2. (I wasn't able to link the
original and the renamed file).

After submit I will file a bug on co19 to adapt their tests and fix their
Stopwatch.restart test (which assumed that the elapsed time was reset when
calling 'restart').

http://codereview.chromium.org/8537011/diff/2001/tests/corelib/src/StopWatchT...
File tests/corelib/src/StopWatchTest.dart (right):

http://codereview.chromium.org/8537011/diff/2001/tests/corelib/src/StopWatchT...
tests/corelib/src/StopWatchTest.dart:59: if (sw.elapsed() > initial) break;
In the very latest revision I have moved the break on a new line with {}.

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
File tests/corelib/src/StopwatchTest.dart (right):

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
tests/corelib/src/StopwatchTest.dart:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
Look at patch set 2 to see the modifications to the original test.

[Mads Ager (google), 2011-11-11 14:11:09]

lgtm

[ngeoffray, 2011-11-11 14:27:23]

LGTM, if Ivan (who I think was the original contributor of the class?) is OK
with the renaming.

[Ivan Posva, 2011-11-11 16:31:53]

LGTM.

Thanks for the cleanup of the documentation.

-Ivan

http://codereview.chromium.org/8537011/diff/3011/corelib/src/implementation/s...
File corelib/src/implementation/stopwatch_implementation.dart (right):

http://codereview.chromium.org/8537011/diff/3011/corelib/src/implementation/s...
corelib/src/implementation/stopwatch_implementation.dart:44: _start =
Clock.now();
A comment why it is OK to not set _start to null would be helpful.

http://codereview.chromium.org/8537011/diff/3011/corelib/src/stopwatch.dart
File corelib/src/stopwatch.dart (right):

http://codereview.chromium.org/8537011/diff/3011/corelib/src/stopwatch.dart#n...
corelib/src/stopwatch.dart:30: * If the [Stopwatch] is currently not running,
then calling stop does nothing.
line too long?

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
File tests/corelib/src/StopwatchTest.dart (right):

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
tests/corelib/src/StopwatchTest.dart:5: // Dart test program for testing
stopwatch support.
Please try to preserve history when renaming files.

[floitsch, 2011-11-14 13:55:59]

http://codereview.chromium.org/8537011/diff/3011/corelib/src/implementation/s...
File corelib/src/implementation/stopwatch_implementation.dart (right):

http://codereview.chromium.org/8537011/diff/3011/corelib/src/implementation/s...
corelib/src/implementation/stopwatch_implementation.dart:44: _start =
Clock.now();
On 2011/11/11 16:31:54, Ivan Posva wrote:
> A comment why it is OK to not set _start to null would be helpful.

Done.

http://codereview.chromium.org/8537011/diff/3011/corelib/src/stopwatch.dart
File corelib/src/stopwatch.dart (right):

http://codereview.chromium.org/8537011/diff/3011/corelib/src/stopwatch.dart#n...
corelib/src/stopwatch.dart:30: * If the [Stopwatch] is currently not running,
then calling stop does nothing.
On 2011/11/11 16:31:54, Ivan Posva wrote:
> line too long?

Done.

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
File tests/corelib/src/StopwatchTest.dart (right):

http://codereview.chromium.org/8537011/diff/3011/tests/corelib/src/StopwatchT...
tests/corelib/src/StopwatchTest.dart:5: // Dart test program for testing
stopwatch support.
On 2011/11/11 16:31:54, Ivan Posva wrote:
> Please try to preserve history when renaming files.

Done.