Enable frong testing components.

Enable frog testing components.

Respect timeout command-line option.

Use option names with underscores understood by all components.

Improve compact progress report using stdout access.

R=whesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1460

[Bill Hesse, 2011-11-11 13:42:52]

LGTM if the race condition is fixed (or not really there).

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:106: return !timedOut && exitCode != -1 &&
exitCode < 0;
Why the curly braces?

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:194: }
This looks like a race condition - if one test is entered in the queue, and the
process runs and ends before a second test is entered in the queue, then
tryRunTest is called from the test.completedHandler() and this condition is
true.

[Mads Ager (google), 2011-11-11 14:02:07]

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:106: return !timedOut && exitCode != -1 &&
exitCode < 0;
On 2011/11/11 13:42:52, Bill Hesse wrote:
> Why the curly braces?

Thanks. I'll get rid of them. I added that while debugging. :)

http://codereview.chromium.org/8537010/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:194: }
On 2011/11/11 13:42:52, Bill Hesse wrote:
> This looks like a race condition - if one test is entered in the queue, and
the
> process runs and ends before a second test is entered in the queue, then
> tryRunTest is called from the test.completedHandler() and this condition is
> true.

That is true. This is all temporary. I will rip it out as soon as stdout is
closed automatically when there are no other pending tasks. I'll add a TODO
comment and leave it as is until I can rip it all out. In practice the listing
happens so quickly that the problem you are describing does not occur.