Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 8537009: tools/test.dart: Implement --checked option. (Closed)

Created:
9 years, 1 month ago by Bill Hesse
Modified:
9 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

tools/test.dart: Implement --checked option. BUG= TEST=tools/test.dart Committed: https://code.google.com/p/dart/source/detail?r=1455

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix type error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M tests/corelib/test_config.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M tests/standalone/test_config.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
9 years, 1 month ago (2011-11-11 11:34:10 UTC) #1
Mads Ager (google)
lgtm http://codereview.chromium.org/8537009/diff/1/tests/standalone/test_config.dart File tests/standalone/test_config.dart (right): http://codereview.chromium.org/8537009/diff/1/tests/standalone/test_config.dart#newcode17 tests/standalone/test_config.dart:17: Map configuration; Thanks!
9 years, 1 month ago (2011-11-11 11:35:20 UTC) #2
Bill Hesse
9 years, 1 month ago (2011-11-11 11:42:39 UTC) #3
Fix type error.

Powered by Google App Engine
This is Rietveld 408576698