Issue 8528025: Implement more progress modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8528025: Implement more progress modes. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement more progress modes. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1509

Patch Set 1 #

Patch Set 2 : Address review comments #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -4 lines)			Patch
M	tools/testing/dart/test_options.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_progress.dart	View	1	5 chunks	+112 lines, -3 lines	1 comment	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. Possibly make a ProcessIndicator factory that creates the correct type of ProcessIndicator, instead of ...

9 years, 1 month ago (2011-11-14 12:25:05 UTC) #2

Mads Ager (google)

On 2011/11/14 12:25:05, Bill Hesse wrote: > LGTM. > > Possibly make a ProcessIndicator factory ...

9 years, 1 month ago (2011-11-14 15:52:09 UTC) #3

Bill Hesse

9 years, 1 month ago (2011-11-14 16:17:17 UTC) #4

http://codereview.chromium.org/8528025/diff/4001/tools/testing/dart/test_prog...
File tools/testing/dart/test_progress.dart (right):

http://codereview.chromium.org/8528025/diff/4001/tools/testing/dart/test_prog...
tools/testing/dart/test_progress.dart:25: assert(false);
I think we want to throw here, not just throw in checked mode, but continuing in
production mode.  There is no point to continuing here, returning null, and
throwing a null pointer exception when we try to use the progress indicator.

Expand Messages | Collapse Messages