Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issue 8525005: Defer further starting timeout watch dog. (Closed)

Created:
9 years, 1 month ago by Anton Muhin
Modified:
9 years, 1 month ago
Reviewers:
vsm, floitsch, Nikolay
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Defer further starting timeout watch dog. Recent changed made DOMContentLoaded event to fire before than Dart application is ready to run. Therefore the safest bet timeout watchdog is to wait until the document is fully loaded. This reverts commit 162f93c5b4def3f2cac2aa1b00fa1d510d1e9940. Committed: https://code.google.com/p/dart/source/detail?r=1447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M client/tests/client/client.status View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/testing/architecture.py View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
All the credits for loaded even go to Vijay! Thanks a lot, Vijay. @olonho: Kolya, ...
9 years, 1 month ago (2011-11-10 19:32:25 UTC) #1
vsm
lgtm
9 years, 1 month ago (2011-11-11 02:33:35 UTC) #2
floitsch
LGTM
9 years, 1 month ago (2011-11-11 07:57:06 UTC) #3
Nikolay
9 years, 1 month ago (2011-11-11 12:58:53 UTC) #4
Cool, thanks Anton and Vijay! 
I've checked WebKit, and think approach chosen in CL is correct. 
In Source/WebCore/loader/FrameLoader.cpp function
FrameLoader::checkCompleted() calls 
m_frame->document()->setReadyState(Document::Complete);  
only when
m_frame->document()->cachedResourceLoader()->requestCount() == 0
which means that there are no pending requests, and all scripts are loaded.

Powered by Google App Engine
This is Rietveld 408576698