Issue 8524006: Windows produces different output for __FUNCTION__. Canonicalize.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8524006: Windows produces different output for FUNCTION. Canonicalize. (Closed)

Created:
9 years, 1 month ago by turnidge

Modified:
9 years, 1 month ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Windows produces different output for __FUNCTION__. Canonicalize.

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		3 chunks	+13 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cshapiro

9 years, 1 month ago (2011-11-11 00:51:42 UTC) #2

lgtm

LGTM

http://codereview.chromium.org/8524006/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8524006/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:38: #define CURRENT_FUNC
CanonicalFunction(__FUNCTION__)
I think you might want __PRETTY_NAME__ on G++ and __FUNCSIG__ on MSVC for
something more consistent.

I do not have access to a Windows machine to confirm this at the moment.

Expand Messages | Collapse Messages

Issue 8524006: Windows produces different output for __FUNCTION__. Canonicalize. (Closed)

Description

Patch Set 1 #

Messages

Issue 8524006: Windows produces different output for FUNCTION. Canonicalize. (Closed)