Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 8524004: Include <stdarg.h> (Closed)

Created:
9 years, 1 month ago by turnidge
Modified:
9 years, 1 month ago
Reviewers:
cshapiro
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Include <stdarg.h>

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
turnidge
TBR=cshapiro Fix buildbot.
9 years, 1 month ago (2011-11-10 19:18:03 UTC) #1
cshapiro
lgtm
9 years, 1 month ago (2011-11-11 01:23:06 UTC) #2
cshapiro
9 years, 1 month ago (2011-11-11 01:26:19 UTC) #3
http://codereview.chromium.org/8524004/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8524004/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:5: #include <stdarg.h>
This is already included in the vm/globals.h header.  if you made this change
solely to try and fix a build break, it may be worth a rollback now.

Powered by Google App Engine
This is Rietveld 408576698