Issue 8523027: Enable frogium test in bots, and fix checked mode on co19 tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8523027: Enable frogium test in bots, and fix checked mode on co19 tests. (Closed)

Created:
9 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
9 years, 1 month ago

Reviewers:
ngeoffray, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable frogium test in bots, and fix checked mode on co19 tests. Committed: https://code.google.com/p/dart/source/detail?r=1445

Patch Set 1 #

Patch Set 2 : mark failing co19 tests #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -10 lines)			Patch
	M	frog/scripts/buildbot_annotated_steps.py	View	1 2 3	2 chunks	+20 lines, -2 lines	1 comment	Download
	M	tests/co19/co19-frog.status	View	1 2 3 4	5 chunks	+40 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

I was re-running the tests in multiple bot configurations, and I realize I have to ...

9 years, 1 month ago (2011-11-11 02:55:22 UTC) #2

ngeoffray

9 years, 1 month ago (2011-11-11 09:55:58 UTC) #4

LGTM

http://codereview.chromium.org/8523027/diff/4003/frog/scripts/buildbot_annota...
File frog/scripts/buildbot_annotated_steps.py (right):

http://codereview.chromium.org/8523027/diff/4003/frog/scripts/buildbot_annota...
frog/scripts/buildbot_annotated_steps.py:116: cmd.append(flags)
The number of steps are getting out of control. We should probably start having
a helper method to avoid duplicated code like this :)

Expand Messages | Collapse Messages