Issue 8523013: Cache isolate in the StackTrace object to that we don't call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8523013: Cache isolate in the StackTrace object to that we don't call (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cache isolate in the StackTrace object to that we don't call Isolate::Current in the destructor, HandleScope and Zone. TBR=iposva (already reviewed change on other client). Committed: https://code.google.com/p/dart/source/detail?r=1427

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -26 lines)			Patch
M	runtime/vm/allocation.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/allocation.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	runtime/vm/handles.cc	View	1 chunk	+10 lines, -14 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages