Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 8523009: Implement 'compact' progress indicator. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement 'compact' progress indicator. At this point it is not that compact because print always prints a newline and therefore we cannot reuse the same line in the output. I will update that when we have access to stdout stream. Removed asserts that fail when test script is run from runtime directory. Removed debugging output from status file parsing. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1452

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -22 lines) Patch
M tests/corelib/test_config.dart View 1 2 chunks +0 lines, -8 lines 0 comments Download
M tests/standalone/test_config.dart View 1 2 chunks +0 lines, -8 lines 0 comments Download
M tools/test.dart View 2 chunks +3 lines, -1 line 0 comments Download
A tools/testing/dart/test_progress.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-10 20:05:30 UTC) #1
Bill Hesse
9 years, 1 month ago (2011-11-11 10:20:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698