Move doc generator out of frog samples.

Move doc generator out of frog samples.

It's on its way to being a real library now so it isn't a sample anymore.

Committed: https://code.google.com/p/dart/source/detail?r=1482

[Bob Nystrom, 2011-11-11 02:23:15]

Moving the doc generator out of frog/samples into its own home now that it's
getting closer to being a real "library". I *think* this is the right place for
it, but let me know if there's somewhere else you'd prefer it to be.

[Jennifer Messerly, 2011-11-11 02:29:57]

lgtm

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (left):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart#oldc...
utils/dartdoc/dartdoc.dart:45: // TODO(jimhug): This generates really ugly
output with lots of holes.
haha. yes, that TODO is very obsolete :)

[jimhug, 2011-11-11 18:02:31]

lgtm

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/classify.dart
File utils/dartdoc/classify.dart (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/classify.dart#new...
utils/dartdoc/classify.dart:7: * fields here will be used as CSS class names for
the generated spans.
Hmm...  I think that this code should find its way back into frog - at least
over time.  It would be really nice if this could be used here, and in the
dartboard and in other places.  Don't do anything about this yet, but when you
or John starts up serious dartboard work, please figure out how to get this in a
shared place.

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (left):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart#oldc...
utils/dartdoc/dartdoc.dart:45: // TODO(jimhug): This generates really ugly
output with lots of holes.
On 2011/11/11 02:29:58, John Messerly wrote:
> haha. yes, that TODO is very obsolete :)
Whoo hoo!

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:67: '$_totalMembers members in ${elapsed}msec.');
Nice reporting code.

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/docs/styles.css
File utils/dartdoc/docs/styles.css (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/docs/styles.css#n...
utils/dartdoc/docs/styles.css:1: /* Reset */
Hmm...  The review tool shows no change in this file.  Am I missing something?

[Bob Nystrom, 2011-11-11 18:21:28]

Thanks for the review!

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/classify.dart
File utils/dartdoc/classify.dart (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/classify.dart#new...
utils/dartdoc/classify.dart:7: * fields here will be used as CSS class names for
the generated spans.
On 2011/11/11 18:02:31, jimhug wrote:
> Hmm...  I think that this code should find its way back into frog - at least
> over time.  It would be really nice if this could be used here, and in the
> dartboard and in other places.  Don't do anything about this yet, but when you
> or John starts up serious dartboard work, please figure out how to get this in
a
> shared place.

Yeah, I was think of splitting this out into a standalone syntax highlighting
library at some point. I'm not sure if it should be Dart-specific or if we'll
want something closer to a Dart implementation of pygments (which would be handy
since we'll probably want to highlight HTML and CSS at some point, at the very
least).

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (left):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart#oldc...
utils/dartdoc/dartdoc.dart:45: // TODO(jimhug): This generates really ugly
output with lots of holes.
On 2011/11/11 18:02:31, jimhug wrote:
> On 2011/11/11 02:29:58, John Messerly wrote:
> > haha. yes, that TODO is very obsolete :)
> Whoo hoo!

:D

Still need private members, but almost everything else is there now.

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:67: '$_totalMembers members in ${elapsed}msec.');
On 2011/11/11 18:02:31, jimhug wrote:
> Nice reporting code.

Thanks! I was using withTiming() before but that doesn't actually output
anything because I'm not enabling info messages. This seemed like a more direct
solution.

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/docs/styles.css
File utils/dartdoc/docs/styles.css (right):

http://codereview.chromium.org/8515029/diff/1/utils/dartdoc/docs/styles.css#n...
utils/dartdoc/docs/styles.css:1: /* Reset */
On 2011/11/11 18:02:31, jimhug wrote:
> Hmm...  The review tool shows no change in this file.  Am I missing something?

I think Reitveld is smart enough to discover file moves. So it's showing no diff
because I just moved this from frog/samples to here but didn't change anything.
I think.