Issue 8515010: This change refactors TypeAnalyzerTest so that it only includes the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8515010: This change refactors TypeAnalyzerTest so that it only includes the (Closed)

Created:
9 years, 1 month ago by zundel

Modified:
9 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

This change refactors TypeAnalyzerTest so that it only includes the test cases. The infrastructure is moved to a superclass. I want to use this in Compile Time Constant testing. Committed: https://code.google.com/p/dart/source/detail?r=1424

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+370 lines, -352 lines)			Patch
	M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View		4 chunks	+2 lines, -352 lines	0 comments	Download
	A	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java	View		1 chunk	+368 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM http://codereview.chromium.org/8515010/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java (right): http://codereview.chromium.org/8515010/diff/1/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java#newcode47 compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java:47: * exercises code in com.google.dart.compiler.resolver. Is this correct ...

9 years, 1 month ago (2011-11-10 20:51:10 UTC) #2

zundel

9 years, 1 month ago (2011-11-10 20:53:56 UTC) #3

http://codereview.chromium.org/8515010/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java
(right):

http://codereview.chromium.org/8515010/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java:47: *
exercises code in com.google.dart.compiler.resolver.
On 2011/11/10 20:51:10, scheglov wrote:
> Is this correct comment for base class?

Done.

Expand Messages | Collapse Messages