Issue 8514002: Tweak co19 status for frog and dartc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8514002: Tweak co19 status for frog and dartc. (Closed)

Created:
9 years, 1 month ago by ahe

Modified:
9 years, 1 month ago

Reviewers:
jimhug, karlklose, zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Tweak co19 status for frog and dartc. Committed: https://code.google.com/p/dart/source/detail?r=1388

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -23 lines)			Patch
	M	dart/tests/co19/co19-compiler.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	dart/tests/co19/co19-frog.status	View		5 chunks	+9 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jimhug

LGTM! Thanks for taking on the burden of co19 integration. Is there anything that explains ...

9 years, 1 month ago (2011-11-10 15:02:16 UTC) #2

ahe

9 years, 1 month ago (2011-11-10 15:25:29 UTC) #5

On 2011/11/10 15:02:16, jimhug wrote:
> LGTM!
> 
> Thanks for taking on the burden of co19 integration.  Is there anything that
> explains the various @ flags in these tests - and how they're implemented in
the
> harness?  I think that some of this stuff is working in frog - but we don't
have
> the right integration with the tests to ensure the correct behavior.

It is a bit underspecified at the moment, and Unipro is currently mulling over
some additional gotchas that they hadn't known about earlier.

Expand Messages | Collapse Messages