Issue 8513004: Throw and a small fix to If.

Issue 8513004: Throw and a small fix to If. (Closed)

Created:
9 years, 1 month ago by floitsch

Modified:
9 years, 1 month ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Throw and a small fix to If. If fix is slightly hacky, but should go away with our refactoring. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1398

Patch Set 2 : Change diff-base #

Total comments: 4

Patch Set 3 : Address comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -16 lines)			Patch
M	frog/leg/ssa/builder.dart	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	frog/leg/ssa/codegen.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/nodes.dart	View	1 2	5 chunks	+22 lines, -8 lines	0 comments	Download
M	frog/leg/ssa/tracer.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/validate.dart	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
A	frog/tests/leg_only/src/Throw1Test.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
A	frog/tests/leg_only/src/Throw2Test.dart	View	1 2	1 chunk	+39 lines, -0 lines	0 comments	Download
M	tools/testing/test_case.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC http://codereview.chromium.org/8513004/diff/2001/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): http://codereview.chromium.org/8513004/diff/2001/frog/leg/ssa/builder.dart#newcode328 frog/leg/ssa/builder.dart:328: visit(node.expression); Note that expression may be null. http://codereview.chromium.org/8513004/diff/2001/frog/leg/ssa/codegen.dart ...

9 years, 1 month ago (2011-11-10 13:22:37 UTC) #2

kasperl

LGTM. Sounds like you've been discussing the test cases with other people.

9 years, 1 month ago (2011-11-10 13:24:25 UTC) #3

floitsch

9 years, 1 month ago (2011-11-10 14:02:22 UTC) #4

http://codereview.chromium.org/8513004/diff/2001/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/8513004/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:328: visit(node.expression);
On 2011/11/10 13:22:37, ngeoffray wrote:
> Note that expression may be null.

Done.

Expand Messages | Collapse Messages