Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 8513001: Fix syntax error in co19-*.status. (Closed)

Created:
9 years, 1 month ago by ahe
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse, Karl Klose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix syntax error in co19-*.status. Committed: https://code.google.com/p/dart/source/detail?r=1387

Patch Set 1 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M dart/tests/co19/co19-compiler.status View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-runtime.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
9 years, 1 month ago (2011-11-10 09:30:54 UTC) #1
karlklose
LGTM.
9 years, 1 month ago (2011-11-10 09:34:02 UTC) #2
Bill Hesse
This eliminates the error message, but the square brackets are still being interpreted as the ...
9 years, 1 month ago (2011-11-10 10:01:26 UTC) #3
ahe
9 years, 1 month ago (2011-11-10 10:04:23 UTC) #4
On 2011/11/10 10:01:26, Bill Hesse wrote:
> This eliminates the error message, but the square brackets are still being
> interpreted as the start of a new section, with empty boolean expression
inside,
> by the dart status file parser.
> 
> I think the best solution would be to prohibit the use of square brackets in
> file names, but if we can't do that, then I can make the tokenizer ignore
> escaped ones.
> 
> LGTM, but I have to make my code work with it now.

The team making co19 tests have agreed in principle that the filenames are
unfortunate.

Powered by Google App Engine
This is Rietveld 408576698