Issue 8511081: Better fix for client tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511081: Better fix for client tests. (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Better fix for client tests. There was a simple bug in $varMethod. We don't hit this path much--you need to be dynamic & in the DOM library. Committed: https://code.google.com/p/dart/source/detail?r=1497

Patch Set 1 #

Patch Set 2 : update status #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
M	client/tests/client/client.status	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	frog/corejs.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/frogsh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages