Issue 8511056: Parse command-line options into a list of test configurations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511056: Parse command-line options into a list of test configurations. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Parse command-line options into a list of test configurations. This allows to run multiple variants at once: ./tools/test.dart --mode=debug,release --component=most R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1453

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -18 lines)			Patch
M	tools/test.dart	View	1	1 chunk	+8 lines, -5 lines	0 comments	Download
M	tools/testing/dart/status_expression.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	5 chunks	+97 lines, -11 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8511056/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): http://codereview.chromium.org/8511056/diff/1/tools/testing/dart/test_options.dart#newcode185 tools/testing/dart/test_options.dart:185: */ Note that it calls itself recursively to ...

9 years, 1 month ago (2011-11-11 10:28:50 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-11 10:57:44 UTC) #3

http://codereview.chromium.org/8511056/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8511056/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:185: */
On 2011/11/11 10:28:50, Bill Hesse wrote:
> Note that it calls itself recursively to expand multiple keys?

Done.

Expand Messages | Collapse Messages