Issue 8511001: Reapply directory error handling change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511001: Reapply directory error handling change. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Reapply directory error handling change. Refactor code to have Platform::StrError(int error_code) on all platforms. Use that to get better error messages on Windows as well. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1344

Patch Set 1 #

Patch Set 2 : Fix Windows build #

Patch Set 3 : Cut down on includes in posix version. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -58 lines)			Patch
M	runtime/bin/directory_impl.dart	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/bin/directory_posix.cc	View	1 2	6 chunks	+58 lines, -30 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	1	4 chunks	+53 lines, -25 lines	0 comments	Download
M	runtime/bin/platform.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_linux.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_macos.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_win.cc	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages