Fix String.trim implementation (follow spec).

Fix String.trim implementation (follow spec).
Fix Queue.every, Queue.some, Queue.filter, ..
Adapt co19 status files.
Committed: https://code.google.com/p/dart/source/detail?r=1521

[siva, 2011-11-14 21:26:17]

LGTM once comment regarding modification while iterating is addressed.

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
File corelib/src/implementation/queue.dart (right):

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
corelib/src/implementation/queue.dart:185: entry = nextEntry;
How will this protect against somebody writing an
'f' that removes both entry and entry._next from the queue.

Shouldn't we just throw some kind of ConcurrentModification Exception when we
detect that the code modifies a collection directly while it is iterating over
the collection.

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart
File runtime/lib/string.dart (right):

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart#newcode180
runtime/lib/string.dart:180: if ((first == 0) && (last == len - 1)) {
(len - 1)

[hausner, 2011-11-14 21:58:02]

LGTM but I don't think the queue implementation is right yet.

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
File corelib/src/implementation/queue.dart (right):

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
corelib/src/implementation/queue.dart:185: entry = nextEntry;
I agree with Siva's comment. Probably need to have some sort of mutation count
or something.

On 2011/11/14 21:26:17, asiva wrote:
> How will this protect against somebody writing an
> 'f' that removes both entry and entry._next from the queue.
> 
> Shouldn't we just throw some kind of ConcurrentModification Exception when we
> detect that the code modifies a collection directly while it is iterating over
> the collection.

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart
File runtime/lib/string.dart (right):

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart#newcode175
runtime/lib/string.dart:175: for (int i = last; last >= first; last--) {
what is this definition of int i good for? Just a reflex of the programmer after
wrinting "for (" :)

[srdjan, 2011-11-14 22:15:33]

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
File corelib/src/implementation/queue.dart (right):

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
corelib/src/implementation/queue.dart:185: entry = nextEntry;
On 2011/11/14 21:26:17, asiva wrote:
> How will this protect against somebody writing an
> 'f' that removes both entry and entry._next from the queue.

It is possible for programmers to write the closures in a non-functional way so
that the list is modified twice during one for each. It is much rarer situation
than the typical usage, and closure itself cannot modify the list, only the
entry.

Filed a bug for ConcurrentModification clarification (442)

> 
> Shouldn't we just throw some kind of ConcurrentModification Exception when we
> detect that the code modifies a collection directly while it is iterating over
> the collection.

http://codereview.chromium.org/8510066/diff/9/corelib/src/implementation/queu...
corelib/src/implementation/queue.dart:185: entry = nextEntry;
On 2011/11/14 21:58:02, hausner wrote:
> I agree with Siva's comment. Probably need to have some sort of mutation count
> or something.
> 

Filed bug 442 for clarification of modification behavior.

> On 2011/11/14 21:26:17, asiva wrote:
> > How will this protect against somebody writing an
> > 'f' that removes both entry and entry._next from the queue.
> > 
> > Shouldn't we just throw some kind of ConcurrentModification Exception when
we
> > detect that the code modifies a collection directly while it is iterating
over
> > the collection.
>

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart
File runtime/lib/string.dart (right):

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart#newcode175
runtime/lib/string.dart:175: for (int i = last; last >= first; last--) {
On 2011/11/14 21:58:02, hausner wrote:
> what is this definition of int i good for? Just a reflex of the programmer
after
> wrinting "for (" :)

Removed int i"

http://codereview.chromium.org/8510066/diff/9/runtime/lib/string.dart#newcode180
runtime/lib/string.dart:180: if ((first == 0) && (last == len - 1)) {
On 2011/11/14 21:26:17, asiva wrote:
> (len - 1)

Done.