Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 8509031: Revert r1380 that is breaking frog. (Closed)

Created:
9 years, 1 month ago by regis
Modified:
9 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert r1380 that is breaking frog. Committed: https://code.google.com/p/dart/source/detail?r=1382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -350 lines) Patch
M runtime/lib/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.h View 4 chunks +5 lines, -19 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 17 chunks +66 lines, -131 lines 0 comments Download
M runtime/vm/class_finalizer_test.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M runtime/vm/code_generator_ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/code_generator_ia32_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/code_index_table_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 2 chunks +0 lines, -11 lines 0 comments Download
M runtime/vm/object.cc View 11 chunks +154 lines, -148 lines 0 comments Download
M runtime/vm/object_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 6 chunks +5 lines, -15 lines 0 comments Download
M runtime/vm/parser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/resolver_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
TBR
9 years, 1 month ago (2011-11-10 01:46:12 UTC) #1
srdjan
9 years, 1 month ago (2011-11-10 01:51:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698