Issue 8508054: Getting started on options parsing.

Issue 8508054: Getting started on options parsing. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Getting started on options parsing. Support the most common options. So far only the --tasks/-j option is actually used. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1405

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -12 lines)			Patch
M	tests/corelib/test_config.dart	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/standalone/test_config.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tools/test.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
A	tools/testing/dart/test_options.dart	View	1	1 chunk	+223 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM! http://codereview.chromium.org/8508054/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): http://codereview.chromium.org/8508054/diff/1/tools/testing/dart/test_options.dart#newcode185 tools/testing/dart/test_options.dart:185: name.startsWith('--') ? buffer.add('=') : buffer.add(' '); Factor the ...

9 years, 1 month ago (2011-11-10 14:59:38 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-10 15:42:46 UTC) #3

http://codereview.chromium.org/8508054/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8508054/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:185: name.startsWith('--') ?
buffer.add('=') : buffer.add(' ');
On 2011/11/10 14:59:38, Bill Hesse wrote:
> Factor the buffer.ȧdd() outside the conditional expression?

Yes. Done!

http://codereview.chromium.org/8508054/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:213: if (option.keys.lastIndexOf(name) !=
-1) {
On 2011/11/10 14:59:38, Bill Hesse wrote:
> or option.keys.some((key)-> key == name)

Yeah, or indexOf. Really didn't mean lastIndexOf here. I'll use some for now.
Thanks. :)

Expand Messages | Collapse Messages