Create class AST nodes.

Create class AST nodes.

Committed: https://code.google.com/p/dart/source/detail?r=1399

[kasperl, 2011-11-10 06:37:34]

LGTM.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:21: void endClass(int interfacesCount, Token
beginToken, Token extendsKeyword,
Nit: Somehow the use of keyword in this file seems a bit too precise. Maybe
rename extendsKeyword to extendsToken (and friends) to make it clear that
whether or not something is a keyword is a detail.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.dart
File dart/frog/leg/scanner/parser.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:11: Function beginTypeArguments;
I think these function fields deserve a comment. What's the purpose of them? I
guess it's cached versions of all the functions you pass to parseStuff?

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:289: Token parseStuff(Token token, Function
beginStuff, Function stuffParser,
It would be nice with a more saying name for this. For now, a comment would
probably help (explain the format of what parseStuff deals with).

[ahe, 2011-11-10 07:59:46]

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.dart
File dart/frog/leg/scanner/parser.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:11: Function beginTypeArguments;
On 2011/11/10 06:37:34, kasperl wrote:
> I think these function fields deserve a comment. What's the purpose of them? I
> guess it's cached versions of all the functions you pass to parseStuff?

I'll wrap these in a class and clean it up. After I have added the grouping
stack to the scanner. I should be able to do so and let V8 recognize each
production as a seperate class, hopefully making all ICs monomorphic.

[ngeoffray, 2011-11-10 08:27:42]

LGTM! Thanks for the testing/leg_only fix.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:256: TypeAnnotation supertype = popNode();
Type variables were already popped, or not pushed?

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:353: TypeAnnotation supertype = popNode();
TODO(ahe): type variables?

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.dart
File dart/frog/leg/scanner/parser.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:197: listener.handleNoType(token);
Should that be handleNoSuperType instead?

[ahe, 2011-11-10 13:37:23]

Hi Kasper and Nicolas,

Thanks for taking a look.

Cheers,
Peter

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:21: void endClass(int interfacesCount, Token
beginToken, Token extendsKeyword,
On 2011/11/10 06:37:34, kasperl wrote:
> Nit: Somehow the use of keyword in this file seems a bit too precise. Maybe
> rename extendsKeyword to extendsToken (and friends) to make it clear that
> whether or not something is a keyword is a detail.

In this case, I think I get the maximum value from writing:

Token extendsKeyword

Compared to:

Token extendsToken

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:256: TypeAnnotation supertype = popNode();
On 2011/11/10 08:27:42, ngeoffray wrote:
> Type variables were already popped, or not pushed?

Already popped, see endTypeVariable below.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:353: TypeAnnotation supertype = popNode();
On 2011/11/10 08:27:42, ngeoffray wrote:
> TODO(ahe): type variables?

Done.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.dart
File dart/frog/leg/scanner/parser.dart (right):

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:197: listener.handleNoType(token);
On 2011/11/10 08:27:42, ngeoffray wrote:
> Should that be handleNoSuperType instead?

Not necessarily. I could change it if someone has a concrete use case.

http://codereview.chromium.org/8508016/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:289: Token parseStuff(Token token, Function
beginStuff, Function stuffParser,
On 2011/11/10 06:37:34, kasperl wrote:
> It would be nice with a more saying name for this. For now, a comment would
> probably help (explain the format of what parseStuff deals with).

Added TODO.