Here's a template for how I plan on doing error-checking on inputs for

Here's a template for how I plan on doing error-checking on inputs for
dart api functions.

Any comments before I change everything?

Any way I could get away without creating the extra Object handle by
doing sneaky tricks?

[Ivan Posva, 2011-11-10 00:12:55]

LGTM, and I can't think of a better name for the macro either.

-Ivan

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:30: #define UNWRAP_NONNULL(dart_handle, vm_handle,
Type)                    \
How about adding a line like this here:

Type& vm_handle = Type::Handle();

This would avoid having to duplicating the handle allocation everywhere.

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:43: }                                               
                   \
\ at column 80.

[turnidge, 2011-11-10 17:48:57]

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:30: #define UNWRAP_NONNULL(dart_handle, vm_handle,
Type)                    \
I tried this and it was a bit too magical for me.  I like having the handle
declaration outside of the macro to make it easier to guess what is going on. 
Okay?

On 2011/11/10 00:12:55, Ivan Posva wrote:
> How about adding a line like this here:
> 
> Type& vm_handle = Type::Handle();
> 
> This would avoid having to duplicating the handle allocation everywhere.

http://codereview.chromium.org/8507035/diff/1/runtime/vm/dart_api_impl.cc#new...
runtime/vm/dart_api_impl.cc:43: }                                               
                   \
On 2011/11/10 00:12:55, Ivan Posva wrote:
> \ at column 80.

Done.