Make tools/test.dart read standalone.status status file when running tests.

Make tools/test.dart read standalone.status status file when running tests.


BUG=
TEST=tools/test.dart

Committed: https://code.google.com/p/dart/source/detail?r=1358

[Mads Ager (google), 2011-11-09 14:46:53]

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
File tests/standalone/test_config.dart (right):

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:29: new Platform().operatingSystem()});
How about avoiding this indentation by doing:

configuration =
    new Configuration({...,
                       ...,
                       ...});

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:42: testSettingMap.addTest(testSetting,
configuration);
What is a testSetting and why does the testSettingsMap need the configuration?
Since this is unimplemented, maybe leave it out of this change and have a TODO
instead?

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:65: String testName = filename.substring(
I linked what you had before much better. This looks complicated. Is there a
reason for the complication here?

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:68: Set<String> expectations =
testSettingMap.expectations(testName);
I would leave this out for now as well. It doesn't do anything?

[Bill Hesse, 2011-11-09 14:55:39]

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
File tests/standalone/test_config.dart (right):

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:29: new Platform().operatingSystem()});
On 2011/11/09 14:46:53, Mads Ager wrote:
> How about avoiding this indentation by doing:
> 
> configuration =
>     new Configuration({...,
>                        ...,
>                        ...});

Done.

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:42: testSettingMap.addTest(testSetting,
configuration);
On 2011/11/09 14:46:53, Mads Ager wrote:
> What is a testSetting and why does the testSettingsMap need the configuration?
> Since this is unimplemented, maybe leave it out of this change and have a TODO

This is the immediate next thing to be implemented.  A testSetting, in the most
complex case, is something like:
Process* : PASS, TIMEOUT if $mode == debug
or
isolates/IsolateSpawn : PASS, SKIP if $arch == arm

It has a testName, perhaps with a subdirectory, and perhaps with a wildcard
suffix, and a SetExpression that needs to be evaluated in a environment
(configuration).  Since this is the next step, I stubbed it out to test the
stubbing.
> instead?

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:65: String testName = filename.substring(
On 2011/11/09 14:46:53, Mads Ager wrote:
> I linked what you had before much better. This looks complicated. Is there a
> reason for the complication here?

The reason for the complication is that some test directories have
subdirectories, and run the tests in those subdirectories as well.  The test
configuration is looked up in using the relative path to the test.

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:68: Set<String> expectations =
testSettingMap.expectations(testName);
On 2011/11/09 14:46:53, Mads Ager wrote:
> I would leave this out for now as well. It doesn't do anything?

I wanted the design, and the stubs.  That way, I can implement the stubs one by
one and keep it working..

[Mads Ager (google), 2011-11-09 15:12:35]

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
File tests/standalone/test_config.dart (right):

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:29: new Platform().operatingSystem()});
On 2011/11/09 14:55:39, Bill Hesse wrote:
> On 2011/11/09 14:46:53, Mads Ager wrote:
> > How about avoiding this indentation by doing:
> > 
> > configuration =
> >     new Configuration({...,
> >                        ...,
> >                        ...});
> 
> Done.

Could you upload a new snapshot?

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:42: testSettingMap.addTest(testSetting,
configuration);
On 2011/11/09 14:55:39, Bill Hesse wrote:
> On 2011/11/09 14:46:53, Mads Ager wrote:
> > What is a testSetting and why does the testSettingsMap need the
configuration?
> > Since this is unimplemented, maybe leave it out of this change and have a
TODO
> 
> This is the immediate next thing to be implemented.  A testSetting, in the
most
> complex case, is something like:
> Process* : PASS, TIMEOUT if $mode == debug
> or
> isolates/IsolateSpawn : PASS, SKIP if $arch == arm
> 
> It has a testName, perhaps with a subdirectory, and perhaps with a wildcard
> suffix, and a SetExpression that needs to be evaluated in a environment
> (configuration).  Since this is the next step, I stubbed it out to test the
> stubbing.
> > instead?
> 

OK, I would still leave it out of this change until it actually does something.
I don't see much added value at this point and maybe when you start implementing
it you will find that you really want something else in any case.

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:65: String testName = filename.substring(
On 2011/11/09 14:55:39, Bill Hesse wrote:
> On 2011/11/09 14:46:53, Mads Ager wrote:
> > I linked what you had before much better. This looks complicated. Is there a
> > reason for the complication here?
> 
> The reason for the complication is that some test directories have
> subdirectories, and run the tests in those subdirectories as well.  The test
> configuration is looked up in using the relative path to the test.

OK, in that case should you make the directory listing recursive? Right now you
will never get anything that wasn't already covered I think?

http://codereview.chromium.org/8507010/diff/1003/tests/standalone/test_config...
tests/standalone/test_config.dart:68: Set<String> expectations =
testSettingMap.expectations(testName);
On 2011/11/09 14:55:39, Bill Hesse wrote:
> On 2011/11/09 14:46:53, Mads Ager wrote:
> > I would leave this out for now as well. It doesn't do anything?
> 
> I wanted the design, and the stubs.  That way, I can implement the stubs one
by
> one and keep it working..

Same as above. I would wait until it does something. The design might change
when you start implementing it and I find it confusing to have an unimplemented
design in the code. Let's add it as we implement it?

[Bill Hesse, 2011-11-09 15:48:58]

Removed unimplemented classes.

[Mads Ager (google), 2011-11-09 15:49:55]

lgtm