Issue 8506005: Merge the two buffer list implementations

Issue 8506005: Merge the two buffer list implementations (Closed)

Created:
9 years, 1 month ago by Søren Gjesse

Modified:
9 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Merge the two buffer list implementations R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1342

Patch Set 2 : Addressed review comments from ager@ #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -80 lines)			Patch
M	runtime/bin/bin.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/buffer_list.dart	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_stream.dart	View		2 chunks	+2 lines, -48 lines	0 comments	Download
M	runtime/bin/string_stream.dart	View		1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart File runtime/bin/buffer_list.dart (right): http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart#newcode5 runtime/bin/buffer_list.dart:5: /* These are nice comments. Maybe use the ...

9 years, 1 month ago (2011-11-09 09:46:15 UTC) #2

Søren Gjesse

9 years, 1 month ago (2011-11-09 09:58:38 UTC) #3

http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart
File runtime/bin/buffer_list.dart (right):

http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:5: /*
On 2011/11/09 09:46:15, Mads Ager wrote:
> These are nice comments. Maybe use the dart doc format /** */?

Done.

http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:29: * [index()] to determine the index of the first
byte in the buffer.
On 2011/11/09 09:46:15, Mads Ager wrote:
> remove the () from [index()] or use code comments [:index():]. 

Removed () (it is a getter)

http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:42: int peek() {
On 2011/11/09 09:46:15, Mads Ager wrote:
> use '=>' syntax?

Done.

http://codereview.chromium.org/8506005/diff/1/runtime/bin/buffer_list.dart#ne...
runtime/bin/buffer_list.dart:60: * Removed a number of bytes from the buffer
list. Currently the
On 2011/11/09 09:46:15, Mads Ager wrote:
> Removed -> Remove

Done.

Expand Messages | Collapse Messages