Issue 8505026: Update tests, fix printing of doubles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8505026: Update tests, fix printing of doubles. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Update tests, fix printing of doubles. Committed: https://code.google.com/p/dart/source/detail?r=1373

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+9 lines, -0 lines	2 comments	Download
	M	tests/co19/co19-runtime.status	View		2 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Technically LGTM, but see comments below. http://codereview.chromium.org/8505026/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/8505026/diff/1/runtime/vm/object.cc#newcode5265 runtime/vm/object.cc:5265: // Eliminate trailing ...

9 years, 1 month ago (2011-11-09 19:32:01 UTC) #2

srdjan

9 years, 1 month ago (2011-11-09 21:48:55 UTC) #3

http://codereview.chromium.org/8505026/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/8505026/diff/1/runtime/vm/object.cc#newcode5265
runtime/vm/object.cc:5265: // Eliminate trailing 0s, but leave one digit after
'.'.
On 2011/11/09 19:32:01, hausner wrote:
> Doesn't the %f format specifier suppress trailing 0 digits already?

Unfortunately it doesn't.

> 
> Also, your solution doesn't work for floating point numbers with an exponent.

%f does not print an exponent at all.

This is a stop-gap solution until we have added floitsch's FP printing code.

Expand Messages | Collapse Messages