Issue 8503028: Runtime type checking should be skipped for Object as destination type.

Issue 8503028: Runtime type checking should be skipped for Object as destination type. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Runtime type checking should be skipped for Object as destination type. Committed: https://code.google.com/p/dart/source/detail?r=1329

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	runtime/vm/code_generator_ia32.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
	M	runtime/vm/object.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8503028/diff/1/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): http://codereview.chromium.org/8503028/diff/1/runtime/vm/code_generator_ia32.cc#newcode1511 runtime/vm/code_generator_ia32.cc:1511: // Any expression is assignable to the DynamicType ...

9 years, 1 month ago (2011-11-08 21:18:10 UTC) #2

srdjan

9 years, 1 month ago (2011-11-08 21:28:47 UTC) #3

http://codereview.chromium.org/8503028/diff/1/runtime/vm/code_generator_ia32.cc
File runtime/vm/code_generator_ia32.cc (right):

http://codereview.chromium.org/8503028/diff/1/runtime/vm/code_generator_ia32....
runtime/vm/code_generator_ia32.cc:1511: // Any expression is assignable to the
DynamicType or Object. Skip the test.
On 2011/11/08 21:18:10, regis wrote:
> Any expression is always assignable to the Dynamic type and to the Object
type.

Done.

http://codereview.chromium.org/8503028/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

http://codereview.chromium.org/8503028/diff/1/runtime/vm/object.h#newcode720
runtime/vm/object.h:720: Class::Handle(type_class()).IsObjectClass();
On 2011/11/08 21:18:10, regis wrote:
> You can save a handle allocation with:
> return HasResolvedTypeClass() && (type_class() == Object::object_class());

Discussed offline and leaving it as it is (object class is store in object
store).

Expand Messages | Collapse Messages