Fix handling of async IO from pipes on Windows

Fix handling of async IO from pipes on Windows

The handling of async IO on Windows wrongly casted everything to a socket connection. For named pipe based connections this caused reading of invalid memory.

Moved some of the functions to a common superclass and only call showdown for socket connections. For named pipe based connections the Dart part of the code will never send shutdown commands as named pipe based connections start out being closed in one direction and closing the other direction causes a close command.

R=ager@google.com

BUG=dart:363
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1308

[Mads Ager (google), 2011-11-08 09:57:08]

LGTM!

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h
File runtime/bin/eventhandler_win.h (right):

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:202: int flags_;
Should parts of this be private now? I guess flags could be private and probably
the critical section as well?

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:289: next_(NULL) { type_ = kClientSocket; }
Doesn't

  explicit ClientSocket(SOCKET s) : SocketHandle(s), next_(NULL) {
    type_ = kClientSocket;
  }

fit? That would be a more usual indentation.

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:293: next_(NULL) { type_ = kClientSocket; }
Ditto on the indentation.

[Søren Gjesse, 2011-11-08 12:56:50]

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h
File runtime/bin/eventhandler_win.h (right):

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:202: int flags_;
On 2011/11/08 09:57:08, Mads Ager wrote:
> Should parts of this be private now? I guess flags could be private and
probably
> the critical section as well?

Done.

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:289: next_(NULL) { type_ = kClientSocket; }
On 2011/11/08 09:57:08, Mads Ager wrote:
> Doesn't
> 
>   explicit ClientSocket(SOCKET s) : SocketHandle(s), next_(NULL) {
>     type_ = kClientSocket;
>   }
> 
> fit? That would be a more usual indentation.

Done.

http://codereview.chromium.org/8503006/diff/1/runtime/bin/eventhandler_win.h#...
runtime/bin/eventhandler_win.h:293: next_(NULL) { type_ = kClientSocket; }
On 2011/11/08 09:57:08, Mads Ager wrote:
> Ditto on the indentation.

Done.