Issue 8502011: Rephrase some comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8502011: Rephrase some comments. (Closed)

Created:
9 years, 1 month ago by Søren Gjesse

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Rephrase some comments. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1532

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -23 lines)			Patch
M	runtime/bin/directory.dart	View	1 chunk	+3 lines, -4 lines	1 comment	Download
M	runtime/bin/input_stream.dart	View	2 chunks	+10 lines, -11 lines	0 comments	Download
M	runtime/bin/output_stream.dart	View	1 chunk	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

9 years, 1 month ago (2011-11-08 09:35:39 UTC) #2

LGTM.

http://codereview.chromium.org/8502011/diff/1/runtime/bin/directory.dart
File runtime/bin/directory.dart (right):

http://codereview.chromium.org/8502011/diff/1/runtime/bin/directory.dart#newc...
runtime/bin/directory.dart:58: */
Maybe we can leave the argument as a bool, if we also declare
static final bool COMPLETED = true;
static final bool DID_NOT_COMPLETE = false;

Otherwise, I think bool arguments are bad.  But that should be a different
changelist.

Expand Messages | Collapse Messages