Issue 8502008: Fix the TestRunnerTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8502008: Fix the TestRunnerTest. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Fix the TestRunnerTest. Use the correct path to the process_test. Decrease the timeout so the test doesn't wait for 10 seconds. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1286

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	tests/standalone/src/TestRunnerTest.dart	View		2 chunks	+10 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

9 years, 1 month ago (2011-11-08 09:48:06 UTC) #2

lgtm

http://codereview.chromium.org/8502008/diff/1/tests/standalone/src/TestRunner...
File tests/standalone/src/TestRunnerTest.dart (right):

http://codereview.chromium.org/8502008/diff/1/tests/standalone/src/TestRunner...
tests/standalone/src/TestRunnerTest.dart:71: int timeout = 1;
Isn't 1 second a bit extreme?  We won't get flaky timeouts with that value?  I
guess, unless we do, it is fine.

Expand Messages | Collapse Messages