Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 8498009: Fix hang when opening sockets on ports that are not available. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix hang when opening sockets on ports that are not available. Fix TimeoutTest to use free ports instead of using the same port always. This does not work because tests are run in parallel and we can have more than one instance of TimeoutTest running. R=sgjesse@google.com,whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/bin/socket_impl.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/standalone/src/TimeoutTest.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-08 13:03:49 UTC) #1
Søren Gjesse
lgtm
9 years, 1 month ago (2011-11-08 13:19:45 UTC) #2
Bill Hesse
9 years, 1 month ago (2011-11-08 13:20:37 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698