Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 8497042: Allow error-recovery in top-level nodes. (Closed)

Created:
9 years, 1 month ago by ahe
Modified:
9 years, 1 month ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow error-recovery in top-level nodes. Also fix a bunch of broken stuff: presubmit and scanner bench. Committed: https://code.google.com/p/dart/source/detail?r=1352

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased, address review comments, and frogsh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -23 lines) Patch
M dart/frog/frogsh View 1 5 chunks +19 lines, -12 lines 0 comments Download
M dart/frog/leg/scanner/listener.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M dart/frog/leg/scanner/node_scanner_bench.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/frog/leg/scanner/parser.dart View 1 1 chunk +12 lines, -6 lines 0 comments Download
M dart/frog/leg/scanner/scanner_bench.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/language.status View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
TBR
9 years, 1 month ago (2011-11-09 12:57:53 UTC) #1
kasperl
LGTM. http://codereview.chromium.org/8497042/diff/1/dart/frog/leg/scanner/parser.dart File dart/frog/leg/scanner/parser.dart (right): http://codereview.chromium.org/8497042/diff/1/dart/frog/leg/scanner/parser.dart#newcode308 dart/frog/leg/scanner/parser.dart:308: do { Why do you prefer do { ...
9 years, 1 month ago (2011-11-09 12:59:18 UTC) #2
ngeoffray
LGTM
9 years, 1 month ago (2011-11-09 13:04:15 UTC) #3
ahe
9 years, 1 month ago (2011-11-09 13:07:55 UTC) #4
http://codereview.chromium.org/8497042/diff/1/dart/frog/leg/scanner/parser.dart
File dart/frog/leg/scanner/parser.dart (right):

http://codereview.chromium.org/8497042/diff/1/dart/frog/leg/scanner/parser.da...
dart/frog/leg/scanner/parser.dart:308: do {
On 2011/11/09 12:59:18, kasperl wrote:
> Why do you prefer do { } while (true) over while (true) { }?

No particular reason. I was thinking about writing:

do {
  ...
} while (isField !== null);

The current version would be better with while (true) { }.

Powered by Google App Engine
This is Rietveld 408576698