Issue 8497032: Fix crash when running with --report_invocation_count.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8497032: Fix crash when running with --report_invocation_count. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix crash when running with --report_invocation_count. Committed: https://code.google.com/p/dart/source/detail?r=1360

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/isolate.cc	View	1	1 chunk	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8497032/diff/3/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): http://codereview.chromium.org/8497032/diff/3/runtime/vm/isolate.cc#newcode178 runtime/vm/isolate.cc:178: int func_len = functions.IsNull() ? 0 : functions.Length(); ...

9 years, 1 month ago (2011-11-09 01:51:07 UTC) #2

srdjan

9 years, 1 month ago (2011-11-09 16:25:06 UTC) #3

http://codereview.chromium.org/8497032/diff/3/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

http://codereview.chromium.org/8497032/diff/3/runtime/vm/isolate.cc#newcode178
runtime/vm/isolate.cc:178: int func_len = functions.IsNull() ? 0 :
functions.Length();
On 2011/11/09 01:51:08, regis wrote:
> const

Done.

Expand Messages | Collapse Messages

Issue 8497032: Fix crash when running with --report_invocation_count. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages