Parse formal parameters.

Parse formal parameters.

This change also deletes the Parameter node class.

Committed: https://code.google.com/p/dart/source/detail?r=1307

[kasperl, 2011-11-08 12:32:49]

LGTM.

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
File dart/frog/leg/tests/function_parameters.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:6: // print(foo(3) + foo(4));
Looking forward to getting this into frog/tests/leg_only/src/ so we can mark it
as failing instead of commenting things out.

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:9: void foo(int a) {
int foo(int a)?

http://codereview.chromium.org/8497011/diff/1/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/presubmit.py#newcode61
dart/frog/presubmit.py:61: print 'Compiling on Dart VM took %s seconds %s' %
(b(elapsed),
Maybe throw 'in checked mode + compile all' in a local variable to make this
format a bit nicer?

[ahe, 2011-11-08 12:40:31]

Hi Kasper,

Thank you for taking a look.

Cheers,
Peter

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
File dart/frog/leg/tests/function_parameters.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:6: // print(foo(3) + foo(4));
On 2011/11/08 12:32:49, kasperl wrote:
> Looking forward to getting this into frog/tests/leg_only/src/ so we can mark
it
> as failing instead of commenting things out.

+1

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:9: void foo(int a) {
On 2011/11/08 12:32:49, kasperl wrote:
> int foo(int a)?

Done.

http://codereview.chromium.org/8497011/diff/1/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/presubmit.py#newcode61
dart/frog/presubmit.py:61: print 'Compiling on Dart VM took %s seconds %s' %
(b(elapsed),
On 2011/11/08 12:32:49, kasperl wrote:
> Maybe throw 'in checked mode + compile all' in a local variable to make this
> format a bit nicer?

Done.

[ngeoffray, 2011-11-08 12:45:02]

LGTM!

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:387: pushNode(new VariableDefinitions(type,
null, name, null));
last null -> token?

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
File dart/frog/leg/tests/function_parameters.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:6: // print(foo(3) + foo(4));
On 2011/11/08 12:40:31, ahe wrote:
> On 2011/11/08 12:32:49, kasperl wrote:
> > Looking forward to getting this into frog/tests/leg_only/src/ so we can mark
> it
> > as failing instead of commenting things out.
> 
> +1

Rebase and you should have it there :)

[ahe, 2011-11-08 12:48:04]

Hi Nicolas,

Good catch on the token!

Cheers,
Peter

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/scanner/listener....
File dart/frog/leg/scanner/listener.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/scanner/listener....
dart/frog/leg/scanner/listener.dart:387: pushNode(new VariableDefinitions(type,
null, name, null));
On 2011/11/08 12:45:02, ngeoffray wrote:
> last null -> token?

Done.

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
File dart/frog/leg/tests/function_parameters.dart (right):

http://codereview.chromium.org/8497011/diff/1/dart/frog/leg/tests/function_pa...
dart/frog/leg/tests/function_parameters.dart:6: // print(foo(3) + foo(4));
On 2011/11/08 12:45:02, ngeoffray wrote:
> On 2011/11/08 12:40:31, ahe wrote:
> > On 2011/11/08 12:32:49, kasperl wrote:
> > > Looking forward to getting this into frog/tests/leg_only/src/ so we can
mark
> > it
> > > as failing instead of commenting things out.
> > 
> > +1
> 
> Rebase and you should have it there :)

Ooh. You speak git now ;-)