Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 8492007: Implementation of Platform class that exposes information about the machine and the OS. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementation of Platform class that exposes information about the machine and the OS. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -7 lines) Patch
M runtime/bin/bin.gypi View 7 chunks +17 lines, -0 lines 0 comments Download
M runtime/bin/builtin_in.cc View 2 chunks +10 lines, -7 lines 0 comments Download
A runtime/bin/platform.h View 1 chunk +20 lines, -0 lines 0 comments Download
A runtime/bin/platform.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A runtime/bin/platform.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A runtime/bin/platform_impl.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A runtime/bin/platform_linux.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A runtime/bin/platform_macos.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A runtime/bin/platform_win.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A tests/standalone/src/PlatformTest.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-07 14:23:53 UTC) #1
Søren Gjesse
9 years, 1 month ago (2011-11-07 14:44:37 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698