Issue 8491052: Minor code clean-ups addressing Nicolas suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8491052: Minor code clean-ups addressing Nicolas suggestions (Closed)

Created:
9 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
9 years, 1 month ago

Reviewers:
Emily Fortuna, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Minor code clean-ups addressing Nicolas suggestions Committed: https://code.google.com/p/dart/source/detail?r=1478

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -86 lines)			Patch
	M	frog/scripts/buildbot_annotated_steps.py	View	1	2 chunks	+35 lines, -70 lines	2 comments	Download
	M	tools/testing/architecture.py	View		3 chunks	+6 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Much nicer with the refactoring! lgtm http://codereview.chromium.org/8491052/diff/3001/frog/scripts/buildbot_annotated_steps.py File frog/scripts/buildbot_annotated_steps.py (right): http://codereview.chromium.org/8491052/diff/3001/frog/scripts/buildbot_annotated_steps.py#newcode86 frog/scripts/buildbot_annotated_steps.py:86: if TestStep("frog tests", ...

9 years, 1 month ago (2011-11-11 21:49:57 UTC) #2

Siggi Cherem (dart-lang)

http://codereview.chromium.org/8491052/diff/3001/frog/scripts/buildbot_annotated_steps.py File frog/scripts/buildbot_annotated_steps.py (right): http://codereview.chromium.org/8491052/diff/3001/frog/scripts/buildbot_annotated_steps.py#newcode86 frog/scripts/buildbot_annotated_steps.py:86: if TestStep("frog tests", testpy_mode, arch, On 2011/11/11 21:49:57, Emily ...

9 years, 1 month ago (2011-11-11 22:20:19 UTC) #3

LGTM! Thanks Siggi

Expand Messages | Collapse Messages

Issue 8491052: Minor code clean-ups addressing Nicolas suggestions (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages