Capturing for loop variables correctly

Capturing for loop variables correctly

Re-introduce a "fresh copy" of the for loop variable(s) in each iteration. Adding a minimal test to check that closures capture the value of the particular loop iteration. 
Committed: https://code.google.com/p/dart/source/detail?r=1273

[regis, 2011-11-07 22:31:47]

LGTM

http://codereview.chromium.org/8490019/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8490019/diff/1/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:294: // Make a copy of the given context, including
the value of the captured
values

http://codereview.chromium.org/8490019/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8490019/diff/1/runtime/vm/parser.cc#newcode4373
runtime/vm/parser.cc:4373: init_scope->VariableAt(i)->owner() == init_scope) {
missing parenthesis

[hausner, 2011-11-07 22:36:35]

Thank you!

http://codereview.chromium.org/8490019/diff/1/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

http://codereview.chromium.org/8490019/diff/1/runtime/vm/code_generator.cc#ne...
runtime/vm/code_generator.cc:294: // Make a copy of the given context, including
the value of the captured
On 2011/11/07 22:31:47, regis wrote:
> values

Done.

http://codereview.chromium.org/8490019/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8490019/diff/1/runtime/vm/parser.cc#newcode4373
runtime/vm/parser.cc:4373: init_scope->VariableAt(i)->owner() == init_scope) {
On 2011/11/07 22:31:47, regis wrote:
> missing parenthesis

Done.