unary operators

unary operators
+4 tests passing, -5 lines in frogsh

Committed: https://code.google.com/p/dart/source/detail?r=1237

[jimhug, 2011-11-06 18:29:26]

TBR

[Jennifer Messerly, 2011-11-07 21:29:53]

lgtm

http://codereview.chromium.org/8487003/diff/1/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8487003/diff/1/frog/gen.dart#newcode1670
frog/gen.dart:1670: index = assignTemp(tmpindex, index);
for consistency, I'd remove this line, and change the invoke of "\$setindex"
below to be:

var ret = assignTemp(tmptarget, target).invoke(this, '\$setindex',
    position, new Arguments(null, [assignTemp(tmpindex, index), y]));

using assignTemp inline prevents someone from accidentally assigning twice. The
code is correct as it is though.

http://codereview.chromium.org/8487003/diff/1/frog/gen.dart#newcode1729
frog/gen.dart:1729: var newVal = value.convertToNonNullBool(this, node);
Ah. I was wondering why we had the extra non-null bool converts in the generated
code.

FWIW, I could not find anything in the spec that says this should use a "boolean
conversion" here. Although it does say we should be using them for && and ||,
which I don't think we are currently (unless you fixed that in another CR). So
this seems consistent & I agree the right fix.

http://codereview.chromium.org/8487003/diff/1/frog/gen.dart#newcode1739
frog/gen.dart:1739: if (node.op.kind == TokenKind.BIT_NOT) {
this is so much nicer.

http://codereview.chromium.org/8487003/diff/1/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8487003/diff/1/frog/member.dart#newcode863
frog/member.dart:863: // TODO(jimhug): target really shouldn't ever be null...
It's null for constructors, factories, and static (including top-level) methods.
Basically anything that's resolved statically.

I wonder if we should always have a target, but use a Value that represents the
type?

http://codereview.chromium.org/8487003/diff/1/frog/member.dart#newcode1197
frog/member.dart:1197: // TODO(jimhug): need a better annotation for being an
operator method
+1 :)