Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Issue 8486009: Optimize the processing of test options. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Optimize the processing of test options. Read the entire file in one go and find all matches of the regexps. This reads the file with the assumption that one byte is a char. For the things we are looking for that will be ok. No need to pass special options to get a larger new space. We run corelib, standalone and co19 in roughly 10sec on my machine. With the python version we are at 6sec. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1569

Patch Set 1 #

Patch Set 2 : Just read the bytes directly from the file. #

Total comments: 2

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -54 lines) Patch
M tests/co19/test_config.dart View 1 1 chunk +34 lines, -22 lines 0 comments Download
M tests/corelib/test_config.dart View 1 1 chunk +28 lines, -16 lines 0 comments Download
M tests/standalone/test_config.dart View 1 2 1 chunk +30 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bill Hesse
LGTM. http://codereview.chromium.org/8486009/diff/2001/tests/co19/test_config.dart File tests/co19/test_config.dart (right): http://codereview.chromium.org/8486009/diff/2001/tests/co19/test_config.dart#newcode111 tests/co19/test_config.dart:111: RegExp testOptionsRegExp = const RegExp(@"// VMOptions=(.*)"); .* does ...
9 years, 1 month ago (2011-11-16 13:47:24 UTC) #1
Mads Ager (google)
9 years, 1 month ago (2011-11-16 14:40:37 UTC) #2
http://codereview.chromium.org/8486009/diff/2001/tests/co19/test_config.dart
File tests/co19/test_config.dart (right):

http://codereview.chromium.org/8486009/diff/2001/tests/co19/test_config.dart#...
tests/co19/test_config.dart:111: RegExp testOptionsRegExp = const RegExp(@"//
VMOptions=(.*)");
On 2011/11/16 13:47:24, Bill Hesse wrote:
> .* does not match newline, so these can match single lines in a multiline
> string.  Add comment?

Yes, thanks. I actually didn't think about that. I was just lucky that it
worked. ;-)

Powered by Google App Engine
This is Rietveld 408576698