Chromium Code Reviews
DescriptionOptimize the processing of test options.
Read the entire file in one go and find all matches of the regexps.
This reads the file with the assumption that one byte is a char.
For the things we are looking for that will be ok.
No need to pass special options to get a larger new space. We
run corelib, standalone and co19 in roughly 10sec on my machine.
With the python version we are at 6sec.
R=whesse@google.com
BUG=
TEST=
Committed: https://code.google.com/p/dart/source/detail?r=1569
Patch Set 1 #Patch Set 2 : Just read the bytes directly from the file. #
Total comments: 2
Patch Set 3 : Address review comments. #
Messages
Total messages: 2 (0 generated)
|
|||||||||||||||||||||||||||||||||||||