https://code.google.com/p/dart/issues/detail?id=255

https://code.google.com/p/dart/issues/detail?id=255
Committed: https://code.google.com/p/dart/source/detail?r=1317

[mmendez, 2011-11-08 15:24:06]

LGTM

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:891:
JsInvocation constructorInvocation =
maybeGenerateSuperOrRedirectCall(constructor);
Nit: I'm not sure that we need this method as is since, it simply goes back and
iterates over the initializers to find the supercall which the loop on line 882
has already done.

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/parser/DartParser.java:1065: return
parseRedirectedConstructorInvocation(null, initializers);
Nit: this follows the existing pattern, but it would be better to try and parser
all of the initializer expressions and then add a check later for redirect
constructors etc.

As it is if there are initializer expressions we give a pretty cryptic error
message about unexpected tokens.

[fabiomfv, 2011-11-08 15:34:55]

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:891:
JsInvocation constructorInvocation =
maybeGenerateSuperOrRedirectCall(constructor);
On 2011/11/08 15:24:06, mmendez wrote:
> Nit: I'm not sure that we need this method as is since, it simply goes back
and
> iterates over the initializers to find the supercall which the loop on line
882
> has already done.

+1. this is not new code and we should refactor. I plan to work on cleaning some
of this as part of the constructor init order bug.

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

http://codereview.chromium.org/8479041/diff/5006/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/parser/DartParser.java:1065: return
parseRedirectedConstructorInvocation(null, initializers);
On 2011/11/08 15:24:06, mmendez wrote:
> Nit: this follows the existing pattern, but it would be better to try and
parser
> all of the initializer expressions and then add a check later for redirect
> constructors etc.
> 
> As it is if there are initializer expressions we give a pretty cryptic error
> message about unexpected tokens.

+1. we need proper error recovery.