Issue 8478014: convert isolate TestFramework from Promise Future

Issue 8478014: convert isolate TestFramework from Promise Future (Closed)

Created:
9 years, 1 month ago by mattsh

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang), siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

convert TestFramework to Future BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1228

Patch Set 2 : change TestFramework to Future #

Total comments: 2

Patch Set 3 : review comments #

Patch Set 4 : fix typos #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -19 lines)			Patch
M	tests/isolate/src/Mixed2Test.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/isolate/src/PromiseBasedTest.dart	View	1	2 chunks	+11 lines, -9 lines	0 comments	Download
M	tests/isolate/src/TestFramework.dart	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

http://codereview.chromium.org/8478014/diff/2001/tests/isolate/src/TestFramework.dart File tests/isolate/src/TestFramework.dart (right): http://codereview.chromium.org/8478014/diff/2001/tests/isolate/src/TestFramework.dart#newcode287 tests/isolate/src/TestFramework.dart:287: class TestPromise<T> extends PromiseImpl<T> { is this still used? ...

9 years, 1 month ago (2011-11-04 21:51:32 UTC) #2

mattsh

9 years, 1 month ago (2011-11-04 22:29:04 UTC) #3

lgtm

Expand Messages | Collapse Messages