Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 8477026: Change the handling of the close event in the StringInputStream (Closed)

Created:
9 years, 1 month ago by Søren Gjesse
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change the handling of the close event in the StringInputStream When the underlying InputStream issues a close event keep track of when the final string data have been read from the StringInputStream. When all string data have been read schedule a callback of the close event. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -11 lines) Patch
M runtime/bin/string_stream.dart View 8 chunks +36 lines, -11 lines 0 comments Download
M tests/standalone/src/StringStreamTest.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years, 1 month ago (2011-11-07 13:27:33 UTC) #1
Bill Hesse
9 years, 1 month ago (2011-11-07 13:43:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698