Ensure ClassElementImplementation removed from ThreadLocal set to prevent memory leak

Ensure ClassElementImplementation removed from ThreadLocal set to prevent memory leak
Committed: https://code.google.com/p/dart/source/detail?r=1259

[danrubel, 2011-11-07 11:13:07]

Fix for http://code.google.com/p/dart/issues/detail?id=319

http://codereview.chromium.org/8477025/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java
(right):

http://codereview.chromium.org/8477025/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java:351:
} finally {
Added try/finally to ensure "this" was removed from set

[Brian Wilkerson, 2011-11-07 14:18:47]

LGTM.

I think this should take care of the problem, but you should probably also have
someone on the compiler team review this. I don't know what this class is doing,
but it seems very strange to me that it's using exceptions to signal compilation
errors (at least that's what it looks like it's doing), and as a result we're
limiting the number of errors we can report at any one time, which also seems
bad.

[danrubel, 2011-11-07 14:44:47]

On 2011/11/07 14:18:47, Brian Wilkerson wrote:
> I think this should take care of the problem, but you should probably also
have
> someone on the compiler team review this.

Good point. 
Konstantin, would you take a look at this?

[scheglov, 2011-11-07 15:02:10]

LGTM

I don't know why exceptions are used, but in any case, try/finally is good idea.