Issue 8476005: Support for --machine-problems, tests for PrettyErrorFormatter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8476005: Support for --machine-problems, tests for PrettyErrorFormatter (Closed)

Created:
9 years, 1 month ago by scheglov

Modified:
9 years, 1 month ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Support for --machine-problems, tests for PrettyErrorFormatter R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1261

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+309 lines, -18 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	2 chunks	+12 lines, -0 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/CompilerConfiguration.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultDartCompilerListener.java	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultErrorFormatter.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DelegatingCompilerConfiguration.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java	View	4 chunks	+32 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/testing/TestCompilerConfiguration.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/runner/DartRunner.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java	View	1 chunk	+232 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

9 years, 1 month ago (2011-11-04 19:21:34 UTC) #2

lgtm

http://codereview.chromium.org/8476005/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/CommandLineOptions.java (right):

http://codereview.chromium.org/8476005/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/CommandLineOptions.java:45: usage =
"Print problems with all details")
Format errors for machine parsing

Expand Messages | Collapse Messages