Issue 8475013: Emit node id at every call to runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8475013: Emit node id at every call to runtime. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Emit node id at every call to runtime. Committed: https://code.google.com/p/dart/source/detail?r=1226

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -46 lines)			Patch
M	runtime/vm/ast.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1 2	32 chunks	+61 lines, -38 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Just a detail (feel free to ignore): Seeing AstNode::kInvalidId passed as parameter feels like ...

9 years, 1 month ago (2011-11-04 22:14:55 UTC) #2

srdjan

9 years, 1 month ago (2011-11-04 22:24:38 UTC) #3

Changing yo kNoId and submitting.

On 2011/11/04 22:14:55, regis wrote:
> LGTM
> 
> Just a detail (feel free to ignore):
> Seeing AstNode::kInvalidId passed as parameter feels like something is wrong.
> How about renaming it toAstNode::kNoId or 
> AstNode::kNoNodeId?

Expand Messages | Collapse Messages