Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 8472007: Fix gclient runhooks on Windows for a full checkout. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix gclient runhooks on Windows for a full checkout. The problem was incorrect setting of and use of the DEPTH gyp variable. R=whesse@google.com BUG=496 TEST= Committed: https://code.google.com/p/dart/source/detail?r=1706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M runtime/bin/bin.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/tools/generate_projects.py View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/generate_projects.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/get_drt.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-21 15:39:36 UTC) #1
Bill Hesse
9 years, 1 month ago (2011-11-21 15:46:09 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698