Issue 8469020: Dartium debug mode runs with VM in release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8469020: Dartium debug mode runs with VM in release mode. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
vsm

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Dartium debug mode runs with VM in release mode. Committed: https://code.google.com/p/dart/source/detail?r=1438

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tests/language/language.status	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

Can you test? I also needed: [ $component == dartium && $mode == debug ] ...

9 years, 1 month ago (2011-11-11 01:16:59 UTC) #2

vsm

9 years, 1 month ago (2011-11-11 01:25:49 UTC) #3

http://codereview.chromium.org/8469020/diff/1/tests/language/language.status
File tests/language/language.status (right):

http://codereview.chromium.org/8469020/diff/1/tests/language/language.status#...
tests/language/language.status:63: [ ($component == vm || $component == dartium)
&& $mode == release ]
Change this to:

[ ($component == vm && $mode == release) || $component == dartium ]

to set this for dartium in debug mode also.

Expand Messages | Collapse Messages