Issue 8469004: Give up on using va_copy for now and get the build working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8469004: Give up on using va_copy for now and get the build working. (Closed)

Created:
9 years, 1 month ago by turnidge

Modified:
9 years ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Give up on using va_copy for now and get the build working.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -20 lines)			Patch
	M	runtime/vm/dart_api_impl.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/dart_api_impl.cc	View		3 chunks	+25 lines, -18 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cshapiro

9 years, 1 month ago (2011-11-11 01:19:29 UTC) #2

lgtm

http://codereview.chromium.org/8469004/diff/3001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8469004/diff/3001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:87: // TODO(turnidge): This clonse Api::Error.  I
need to use va_copy to
clones

http://codereview.chromium.org/8469004/diff/3001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:88: // fix this but not sure if it available on all
of our builds.
Is MSVC the only compiler without va_copy?  If so, maybe add

  #define va_copy(dst ,src) ((dst) = (src))

to the c99 support header

Expand Messages | Collapse Messages