Integrate leg as a component in test.py. Also update presubmit script to run tests with leg.

Integrate leg as a component in test.py. Also update presubmit script to run tests with leg.

[kasperl, 2011-11-04 10:13:00]

LGTM, but I think it's worthwhile to consider how we keep the self-hosting
version of leg running too.

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py#newco...
dart/frog/presubmit.py:75: test_cmd[1] = '--component=leg'
This seems easy to break. Maybe long-term this could be made a bit nicer. For
now, I'd add a comment saying that you're replacing the --component=frog,frogsh
part of the command.

http://codereview.chromium.org/8462004/diff/1011/dart/tests/language/language...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/8462004/diff/1011/dart/tests/language/language...
dart/tests/language/language.status:202: [ $component == frogsh ||  $component
== frog || $component == leg]
leg] => leg ]

http://codereview.chromium.org/8462004/diff/1011/dart/tools/testing/architect...
File dart/tools/testing/architecture.py (right):

http://codereview.chromium.org/8462004/diff/1011/dart/tools/testing/architect...
dart/tools/testing/architecture.py:441: class
LegArchitecture(StandaloneArchitecture):
Should we have a leg and a legsh?

[ngeoffray, 2011-11-04 10:16:44]

Thanks!

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py#newco...
dart/frog/presubmit.py:75: test_cmd[1] = '--component=leg'
On 2011/11/04 10:13:00, kasperl wrote:
> This seems easy to break. Maybe long-term this could be made a bit nicer. For
> now, I'd add a comment saying that you're replacing the
--component=frog,frogsh
> part of the command.

I can actually just add leg as a component line 65. WDYT?

http://codereview.chromium.org/8462004/diff/1011/dart/tests/language/language...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/8462004/diff/1011/dart/tests/language/language...
dart/tests/language/language.status:202: [ $component == frogsh ||  $component
== frog || $component == leg]
On 2011/11/04 10:13:00, kasperl wrote:
> leg] => leg ]

Done.

http://codereview.chromium.org/8462004/diff/1011/dart/tools/testing/architect...
File dart/tools/testing/architecture.py (right):

http://codereview.chromium.org/8462004/diff/1011/dart/tools/testing/architect...
dart/tools/testing/architecture.py:441: class
LegArchitecture(StandaloneArchitecture):
On 2011/11/04 10:13:00, kasperl wrote:
> Should we have a leg and a legsh?

Let's do that in a future cl.

[kasperl, 2011-11-04 10:21:00]

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py
File dart/frog/presubmit.py (right):

http://codereview.chromium.org/8462004/diff/1011/dart/frog/presubmit.py#newco...
dart/frog/presubmit.py:75: test_cmd[1] = '--component=leg'
On 2011/11/04 10:16:44, ngeoffray wrote:
> On 2011/11/04 10:13:00, kasperl wrote:
> > This seems easy to break. Maybe long-term this could be made a bit nicer.
For
> > now, I'd add a comment saying that you're replacing the
> --component=frog,frogsh
> > part of the command.
> 
> I can actually just add leg as a component line 65. WDYT?

Much better.

[ahe, 2011-11-04 10:25:38]

LGTM, very nice!