Issue 8451010: Fix issue 5564152 (VM crash): stack at exit of method was incorrect. Smi equality with Mint was c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8451010: Fix issue 5564152 (VM crash): stack at exit of method was incorrect. Smi equality with Mint was c... (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix issue 5564152 (VM crash): stack at exit of method was incorrect. Smi equality with Mint was calling operator ==, the result was pushed instead of evaluated to either push a boolean object or to jump to a label. Committed: https://code.google.com/p/dart/source/detail?r=1167

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	runtime/vm/opt_code_generator_ia32.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm.

Expand Messages | Collapse Messages